Adding frame config option and removing electron remote library

[IsmaelMartinez]

• Adding frame config option to allow for frameless windows. Closes Hide Title Bar #1444
• Remove @electron/remote as I believe is not in use.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[Shadowfury22]

Uhmm... shouldn't this have a default value of "true" instead of "false"?

frame: {
	default: false,
	describe: 'Specify false to create a Frameless Window. Default is true',
	type: 'string'
},

I got jumpscared by the lack of title bar after updating to 1.11.4 😅

[IsmaelMartinez]

Me bad... I really need some holidays. I will fix it later today and probably release it in a new pre-release. Thanks for reporting it!

…

On Mon, 11 Nov 2024, 05:16 Juanmi, ***@***.***> wrote: Uhmm... shouldn't this have a default value of "true" instead of "false"? frame: { default: false, describe: 'Specify false to create a Frameless Window. Default is true', type: 'string' }, I got jumpscared by the lack of title bar after updating to 1.11.4 😅 — Reply to this email directly, view it on GitHub <#1471 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADJHECACJ4WNRYFJBJQ7TD2AA4RLAVCNFSM6AAAAABRO6DIAKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRXGI2TKNJYHA> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[IsmaelMartinez]

ok, https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.11.5 should have that as a optional option, not the default. Thanks again for reporting it!

[palves]

https://github.com/IsmaelMartinez/teams-for-linux/blob/main/app/config/README.md still reads "false" in the "Default Value" (third) column:

frame Specify false to create a Frameless Window. Default is true false

I would suggest fixing that column's value, and dropping the "Default is true" sentence completely from the second column, as it is redundant.

[IsmaelMartinez]

yep, it looks like a bug. I will see when i can have a look but I think is just the type that is incorrect as described in here #1444 (comment) . Apologies as I have been away due personal family reasons.