-
Notifications
You must be signed in to change notification settings - Fork 84
SDK-218: BCIT End-to-End Deep Link Routing Tests #993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: SDK-216 BCIT App configured for deep link handling (#991)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #993 +/- ##
==========================================
- Coverage 69.77% 69.74% -0.04%
==========================================
Files 111 111
Lines 8983 8983
==========================================
- Hits 6268 6265 -3
- Misses 2715 2718 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joaodordio
approved these changes
Jan 13, 2026
Comment on lines
+35
to
+39
| // MARK: - Browser Link Tests (Run First) | ||
|
|
||
| func testADeepLinkFromRemindersApp() { | ||
| print("🧪 Testing deep link from Reminders app") | ||
| // MARK: - Browser Link Tests | ||
|
|
||
| // MARK: - Browser Link Tests |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| // MARK: - Browser Link Tests (Run First) | |
| func testADeepLinkFromRemindersApp() { | |
| print("🧪 Testing deep link from Reminders app") | |
| // MARK: - Browser Link Tests | |
| // MARK: - Browser Link Tests | |
| // MARK: - Browser Link Tests (Run First) |
sumeruchat
pushed a commit
that referenced
this pull request
Jan 14, 2026
* 'master' of github-iterable:Iterable/iterable-swift-sdk: SDK-218: BCIT End-to-End Deep Link Routing Tests (#993)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This Does
Implements comprehensive deep link testing for the BCIT framework. Tests validate the complete flow from external sources (simulated via Reminders app) into the app, covering URL routing, custom actions, and the critical single-redirect policy.
Key Features
1. External Source Testing
links.tsetester.comthat unwrap to destination URLs2. Single Redirect Policy Validation
RedirectNetworkSession.willPerformHTTPRedirectionreturns nil to stop URLSession from following additional redirects3. Update Screen Navigation
UpdateViewControllerdisplays when links navigate to/update/*paths4. Comprehensive Test Coverage
Testing
Tests use alphabetical prefixes (A, B, C, etc.) to control execution order.
Notes
tsetester.com) with actual AASA file - no mockingRelated Tickets