Skip to content

Conversation

@sumeruchat
Copy link
Contributor

@sumeruchat sumeruchat commented Jan 14, 2026

What

Fixes full-position in-app messages not covering the entire screen edge-to-edge. Previously, full-position IAMs would not extend behind the notch/Dynamic Island and home indicator areas, leaving gaps where the underlying app content was visible.

Changes

  • Modified resizeWebView in IterableHtmlMessageViewController to use screen bounds for full-position IAMs
  • Added coordinate conversion to properly position the webView relative to the view's coordinate system
  • Non-full positions (top, bottom, center) remain unchanged

Impact

  • Breaking changes: None
  • Behavior change: Full-position IAMs now truly cover the entire screen edge-to-edge, including behind the notch/Dynamic Island and home indicator
  • Other positions: Top, bottom, center positions unaffected (original behavior preserved)

Testing

How to test:

  1. Create an in-app message with full position (top=0%, bottom=0%)
  2. Display on device with notch/Dynamic Island (iPhone X or newer)
  3. Verify background extends all the way to screen edges (behind status bar and home indicator)
  4. Test top/bottom/center positions still work correctly

🤖 Generated with Claude Code

sumchattering and others added 2 commits January 14, 2026 07:27
* 'master' of github-iterable:Iterable/iterable-swift-sdk:
  SDK-218: BCIT End-to-End Deep Link Routing Tests (#993)
Apply safe area insets to WKWebView scrollView content for full-position
in-app messages. This ensures content is not hidden behind notch, status
bar, or home indicator while maintaining edge-to-edge background coverage.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.73%. Comparing base (e5176d4) to head (521326e).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...k/Internal/IterableHtmlMessageViewController.swift 92.85% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #996   +/-   ##
=======================================
  Coverage   69.73%   69.73%           
=======================================
  Files         111      111           
  Lines        8983     8995   +12     
=======================================
+ Hits         6264     6273    +9     
- Misses       2719     2722    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants