-
Notifications
You must be signed in to change notification settings - Fork 9
[MOB-12020] playwright GitHub actions setup #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #536 +/- ##
=======================================
Coverage 74.49% 74.49%
=======================================
Files 57 57
Lines 2741 2741
Branches 820 803 -17
=======================================
Hits 2042 2042
- Misses 658 698 +40
+ Partials 41 1 -40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question, but otherwise LGTM!
alias: { | ||
src: path.resolve(__dirname, 'src/'), | ||
'@iterable/web-sdk': path.resolve(__dirname, '../') | ||
'@iterable/web-sdk': path.resolve(__dirname, '../dist/') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have we verified the typical commands for starting the sample app work with this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me double check to make sure that works still for yarn install:all && yarn start:all:react
, and modify as needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed that the typical commands still work!
JIRA Ticket(s) if any
Description - Add Playwright E2E Testing to GitHub Actions CI
This PR adds e2e test to the CI pipeline using Playwright.
Major Changes
🚀 CI Configuration (
.github/workflows/ci.yml
)e2e-tests
job with multi-browser testing (Chromium, Firefox, WebKit)ITERABLE_API_KEY
andJWT_SECRET
📋 Documentation & Testing Practices
🏗️ Architecture Improvements
baseURL
configurationTechnical Summary
Performance Optimizations
Code Quality
CI Process