Skip to content

Commit

Permalink
Merge pull request #603 from johnhaup/move-deps-to-peer-deps
Browse files Browse the repository at this point in the history
Move dependencies to peer dependencies
  • Loading branch information
lposen authored Nov 25, 2024
2 parents 2f87799 + f21d5ef commit ce3309d
Show file tree
Hide file tree
Showing 7 changed files with 38 additions and 31 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.3.21
## Fixes
- Fixes an issue where react native components that use safe-area-context or react-navigation throw an error because the sdk's components try and use its own local node_modules instead of the consumer's project.

## 1.3.20
## Fixes
- Fixes an issue where the iOS SDK incorrectly targeted the latest minor version instead of a fixed version, potentially causing breaking changes.
Expand Down
7 changes: 7 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ Iterable's React Native SDK relies on:
- [React Native 0.60.0+](https://github.com/facebook/react-native)
- [React Native CLI 2.0.1+](https://reactnative.dev/docs/upgrading#react-native-cli)

_UI Components require additional peer dependencies_
- [React Navigation 6+](https://github.com/react-navigation/react-navigation)
- [React Native Safe Area Context 4+](https://github.com/th3rdwave/react-native-safe-area-context)
- [React Native Vector Icons 9+](https://github.com/oblador/react-native-vector-icons)
- [React Native WebView 11+](https://github.com/react-native-webview/react-native-webview)

- **iOS**
- Xcode 12+
- [Deployment target 10.0+](https://help.apple.com/xcode/mac/current/#/deve69552ee5)
Expand Down Expand Up @@ -58,6 +64,7 @@ For quick reference, the following table lists the versions of the [Android SDK]

| RN SDK Version | Android SDK Version | iOS SDK Version |
| --------------------------------------------------------------------------- | ---------------------------------------------------------------------------- | --------------- |
| [1.3.21](https://www.npmjs.com/package/@iterable/react-native-sdk/v/1.3.20) | [3.5.2](https://github.com/Iterable/iterable-android-sdk/releases/tag/3.5.2) | [6.5.4](https://github.com/Iterable/swift-sdk/releases/tag/6.5.4)
| [1.3.20](https://www.npmjs.com/package/@iterable/react-native-sdk/v/1.3.20) | [3.5.2](https://github.com/Iterable/iterable-android-sdk/releases/tag/3.5.2) | [6.5.4](https://github.com/Iterable/swift-sdk/releases/tag/6.5.4)
| [1.3.19](https://www.npmjs.com/package/@iterable/react-native-sdk/v/1.3.19) | [3.5.2](https://github.com/Iterable/iterable-android-sdk/releases/tag/3.5.2) | [6.5.3](https://github.com/Iterable/swift-sdk/releases/tag/6.5.3)
| [1.3.18](https://www.npmjs.com/package/@iterable/react-native-sdk/v/1.3.18) | [3.5.2](https://github.com/Iterable/iterable-android-sdk/releases/tag/3.5.2) | [6.5.3](https://github.com/Iterable/swift-sdk/releases/tag/6.5.3)
Expand Down
2 changes: 1 addition & 1 deletion SampleApp/javascript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"lint": "eslint ."
},
"dependencies": {
"@iterable/react-native-sdk": "^1.3.20",
"@iterable/react-native-sdk": "^1.3.21",
"@react-native-community/masked-view": "^0.1.10",
"@react-native-community/toolbar-android": "^0.1.0-rc.2",
"@react-navigation/bottom-tabs": "^5.4.5",
Expand Down
2 changes: 1 addition & 1 deletion SampleApp/typescript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"lint": "eslint ."
},
"dependencies": {
"@iterable/react-native-sdk": "^1.3.20",
"@iterable/react-native-sdk": "^1.3.21",
"@react-native-community/masked-view": "^0.1.10",
"@react-native-community/toolbar-android": "^0.1.0-rc.2",
"@react-navigation/bottom-tabs": "^5.4.5",
Expand Down
2 changes: 1 addition & 1 deletion integration-testing/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"e2e:android-release": "npm run build:android-release && npm run test:android-release"
},
"dependencies": {
"@iterable/react-native-sdk": "^1.3.20",
"@iterable/react-native-sdk": "^1.3.21",
"@react-native-community/masked-view": "^0.1.10",
"@react-navigation/bottom-tabs": "^5.4.5",
"@react-navigation/native": "^5.4.0",
Expand Down
35 changes: 18 additions & 17 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@iterable/react-native-sdk",
"version": "1.3.20",
"version": "1.3.21",
"description": "Iterable SDK for React Native.",
"main": "./js/index.js",
"types": "./js/index.d.ts",
Expand All @@ -20,45 +20,46 @@
"author": "Iterable",
"license": "MIT",
"homepage": "https://github.com/Iterable/react-native-sdk",
"dependencies": {
"@react-native-community/hooks": "^2.6.0",
"@react-navigation/native": "^6.0.6",
"eslint": "^8.0.1",
"eslint-config-airbnb": "^19.0.4",
"react-native-safe-area-context": "^4.1.2",
"react-native-vector-icons": "^9.0.0",
"react-native-webview": "^11.0.0"
},
"devDependencies": {
"@babel/core": "^7.10.2",
"@react-navigation/native": "^6.0.6",
"@testing-library/react-native": "^7.2.0",
"@types/jest": "^26.0.0",
"@types/react": "^16.9.23",
"@types/react-native": "^0.62.13",
"@types/react-native-vector-icons": "^6.4.10",
"@types/react-native": "^0.62.13",
"@types/react-test-renderer": "^17.0.1",
"@types/react": "^16.9.23",
"@typescript-eslint/eslint-plugin": "^5.0.0",
"eslint-config-standard": "^14.0.0",
"eslint-config-airbnb": "^19.0.4",
"eslint-config-standard-jsx": "^8.1.0",
"eslint-config-standard-react": "^9.2.0",
"eslint-config-standard-with-typescript": "^23.0.0",
"eslint-config-standard": "^14.0.0",
"eslint-plugin-import": "^2.25.2",
"eslint-plugin-n": "^15.0.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-promise": "^6.0.0",
"eslint-plugin-react": "^7.31.10",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-react-native": "^4.0.0",
"eslint-plugin-react": "^7.31.10",
"eslint-plugin-standard": "^4.0.0",
"eslint": "^8.0.1",
"i": "^0.3.5",
"jest": "^26.0.1",
"react": "16.11.0",
"react-native-safe-area-context": "^4.1.2",
"react-native-vector-icons": "^9.0.0",
"react-native-webview": "^11.0.0",
"react-native": "^0.68.0",
"react": "16.11.0",
"ts-jest": "^26.0.0",
"typescript": "^3.9.5"
},
"peerDependencies": {
"react": "*",
"react-native": "*"
"@react-navigation/native": ">=6",
"react-native-safe-area-context": ">=4",
"react-native-vector-icons": ">=9",
"react-native-webview": ">=11",
"react-native": "*",
"react": "*"
}
}
17 changes: 6 additions & 11 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1240,11 +1240,6 @@
sudo-prompt "^9.0.0"
wcwidth "^1.0.1"

"@react-native-community/hooks@^2.6.0":
version "2.8.1"
resolved "https://registry.yarnpkg.com/@react-native-community/hooks/-/hooks-2.8.1.tgz#6e785431db49318048fdd14b601998437b6cc200"
integrity sha512-DCmCIC0Gn9m6K0Mlg2MwNmTxMEpBu5lTLsI6b/XUAv/vLGa6o+X7RhCai4FWeqkjCU36+ZOwaLzDo4NBWMXaoQ==

"@react-native/assets@1.0.0":
version "1.0.0"
resolved "https://registry.yarnpkg.com/@react-native/assets/-/assets-1.0.0.tgz#c6f9bf63d274bafc8e970628de24986b30a55c8e"
Expand Down Expand Up @@ -6163,9 +6158,9 @@ react-native-gradle-plugin@^0.0.6:
integrity sha512-eIlgtsmDp1jLC24dRn43hB3kEcZVqx6DUQbR0N1ABXGnMEafm9I3V3dUUeD1vh+Dy5WqijSoEwLNUPLgu5zDMg==

react-native-safe-area-context@^4.1.2:
version "4.11.0"
resolved "https://registry.yarnpkg.com/react-native-safe-area-context/-/react-native-safe-area-context-4.11.0.tgz#d45271363672dc1923ddb0ce5a6ad588e210c85d"
integrity sha512-Bg7bozxEB+ZS+H3tVYs5yY1cvxNXgR6nRQwpSMkYR9IN5CbxohLnSprrOPG/ostTCd4F6iCk0c51pExEhifSKQ==
version "4.14.0"
resolved "https://registry.yarnpkg.com/react-native-safe-area-context/-/react-native-safe-area-context-4.14.0.tgz#138f4b2e180cb7517c78bd5f4d4cf91325ba0b1a"
integrity sha512-/SyYpCulWQOnnXhRq6wepkhoyQMowHm1ptDyRz20s+YS/R9mbd+mK+jFyFCyXFJn8jp7vFl43VUCgspuOiEbwA==

react-native-vector-icons@^9.0.0:
version "9.2.0"
Expand Down Expand Up @@ -7468,9 +7463,9 @@ url-parse@^1.5.3:
requires-port "^1.0.0"

use-latest-callback@^0.2.1:
version "0.2.1"
resolved "https://registry.yarnpkg.com/use-latest-callback/-/use-latest-callback-0.2.1.tgz#4d4e6a9e4817b13142834850dcfa8d24ca4569cf"
integrity sha512-QWlq8Is8BGWBf883QOEQP5HWYX/kMI+JTbJ5rdtvJLmXTIh9XoHIO3PQcmQl8BU44VKxow1kbQUHa6mQSMALDQ==
version "0.2.3"
resolved "https://registry.yarnpkg.com/use-latest-callback/-/use-latest-callback-0.2.3.tgz#2d644d3063040b9bc2d4c55bb525a13ae3de9e16"
integrity sha512-7vI3fBuyRcP91pazVboc4qu+6ZqM8izPWX9k7cRnT8hbD5svslcknsh3S9BUhaK11OmgTV4oWZZVSeQAiV53SQ==

"use-subscription@>=1.0.0 <1.6.0":
version "1.5.1"
Expand Down

0 comments on commit ce3309d

Please sign in to comment.