prevent crash on disconnect, when scene is removed and code on js side still executed#52
Closed
SamuelBrucksch wants to merge 7 commits intomasterfrom
Closed
prevent crash on disconnect, when scene is removed and code on js side still executed#52SamuelBrucksch wants to merge 7 commits intomasterfrom
SamuelBrucksch wants to merge 7 commits intomasterfrom
Conversation
…e is not valid anymore
SamuelBrucksch
changed the title
SamuelBrucksch
changed the title
Contributor
|
Closing in favor of #54 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When CP was disconnected, the react code still executed and called native functions, but the scene was already destroyed, so it crashed with error
operation failed, AutoPlayRootScene scene not found