This repository has been archived by the owner on Jan 1, 2025. It is now read-only.
Improved Linux SDL Installer #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Are you able to revert the package-lock.json changes? They seem to be causing issues with |
|
Sure! I'll do it tomorrow since I'm about to go to sleep.
…-------- Original Message --------
On May 9, 2024, 12:33 AM, Sim wrote:
Thanks for the PR. Are you able to revert the package-lock.json changes? They seem to be causing issues with npm ci
https://github.com/ItsSim/fsolauncher/actions/runs/9000757521/job/24753354643?pr=85
—
Reply to this email directly, [view it on GitHub](#85 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AT23PEB2XJRTDQHPX3U54L3ZBKR43AVCNFSM6AAAAABHMPQAOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBRGYYDSMRQGA).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
There's a few issues with the formatting: |
|
I know, I'm working on it |
|
Alright, everything seems to work now. God this PR is a nightmare |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unneeded
libsdl2-devdependency for Debian-based systems along with combiningaptInstall()andpacmanInstall()functions intolinuxInstall()along with symlinkinglibSDL2.soto FreeSO's folder on Arm devices since vendored SDL2 from MacExtras is anx86_64library.Edit: I just realized you can probably point FreeSO to use system libraries by editing
MonoGame.Framework.dll.config. I'll first check if this fix work and then I'll try theMonoGame.Framework.dll.configway.Edit 2: The SDL2 and OpenAL installers can actually be "removed" for the Linux version since these packages can be set as dependencies which are automatically installed when installing the package.