This repository has been archived by the owner on Jan 1, 2025. It is now read-only.
Propper fix for Linux theme resetting #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some ESlint errors if you can resolve those |
|
There. I kind of forgot about linting since I was doing everything from a live Linux install to test everything with a proper desktop. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Proposed Changes
Instead of firing
nativeThemeevent only once when running on Linux, it gets fired only when theme's set toauto(Follow System Theme). This basically guarantees that if you change your theme and you have a broken dark theme preference (what appeared to caused the issue for me) the theme change event won't keep reverting it toopen_betaon startup.Additional Info
This PR is basically the proper to do what I did in my yesterday's PR.