Fix 404 for model names containing slashes#13
Merged
Conversation
Enable UseEncodedPath() on the mux router so percent-encoded slashes
(%2F) in model names are not interpreted as path separators. Add
url.PathUnescape() in both handlers that read {name} from the path.
Affects: PATCH /models/{name}/enable, GET /models/{name}/benchmarks
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
google/gemma-3-4b(common with LM Studio / HuggingFace naming) caused 404 errors on the enable/disable toggle and benchmark endpoints%2F, but gorilla/mux decoded it back to/before matching, breaking the routeFix
UseEncodedPath()on the mux router so%2Fstays encoded during route matchingurl.PathUnescape()inhandleSetModelEnabledandhandleGetModelBenchmarksto decode the name for DB lookupsTest plan
go test -short ./...passes/in the name (e.g.google/gemma-3-4bfrom LM Studio)/in the name