feat : main, dev PR시 CI 구현 #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macmorning0116
approved these changes
Jan 7, 2025
| name: CI Pipeline | ||
|
|
||
| on: | ||
| pull_request: |
There was a problem hiding this comment.
혹시 push가 아닌 pr로 하신 이유가 있으실까요?
There was a problem hiding this comment.
이 코드는 CI (빌드->테스트 )까지만 자동화하는거라 main에대해 PR을 날리면 push되기전에 검증하는 로직입니다.
검증 이후 저희 승인을 하고 머지가되면 push가되고 그후에 CD에대한 코드가 작동하고 배포가 되는 flow로 생각하였습니다
Icecoff22
approved these changes
Jan 7, 2025
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: List project files |
There was a problem hiding this comment.
아 이건 디버깅과정에서 gradlew위치를 확인하기 위해 필요했었습니다!
| # Configure Gradle for optimal use in GitHub Actions, including caching of downloaded dependencies. | ||
| # See: https://github.com/gradle/actions/blob/main/setup-gradle/README.md | ||
| - name: Setup Gradle | ||
| uses: gradle/actions/setup-gradle@af1da67850ed9a4cedd57bfd976089dd991e2582 # v4.0.0 |
There was a problem hiding this comment.
gradle 버전관리와 캐시활용해서 이미 다운로드해 둔 의존성(라이브러리)들을 재사용하여, 매번 의존성을 다시 받지 않도록 빌드 속도를 높이는 효과가 있다합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
#157
💭 작업 내용
main, dev 브랜치 PR시 CI 구현
🤔 참고 사항
테스트에 대한 검증은 일단 생략되었습니다.
📸 스크린샷(선택)
💬 리뷰 요구사항(선택)
테스트코드 검증을 포함시킬까요?
snoarqube를 통해 코드 분석 과정을 포함시킬까요?