Multiplayer RoffSystem Fixes #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ROFF system previously used engine time instead of module time when setting the time values for trajectories of shared entities. This caused issues when the server module time has been reset on map change, because the game module would misinterpret the trajectories.
Change type of mVersion in TROFFHeader and TROFF2Header from long to int.
|
Are either of these affected in SP as well? |
No. For SP the relevant roff functions should be in module code and use |
taysta
pushed a commit
to taysta/TaystJK
that referenced
this pull request
Sep 24, 2023
* [MP] Fix ROFF system using incorrect time value. The ROFF system previously used engine time instead of module time when setting the time values for trajectories of shared entities. This caused issues when the server module time has been reset on map change, because the game module would misinterpret the trajectories. * [MP] Fix roff not working on 64 bit builds. Change type of mVersion in TROFFHeader and TROFF2Header from long to int. (cherry picked from commit f90488d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes two multiplayer bugs related to the RoffSystem:
longinstead ifintfor themVersionheader field, causing 64-bit versions to be unable to parse roff files and playing them back.