Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MP] fix off-by-one in TruncateGLExtensionsString #1175

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

Razish
Copy link
Member

@Razish Razish commented Sep 30, 2023

...which affects mods not derived from OJK.

UI_DrawGLInfo has an array of size 128, which was being filled from a GL extensions string of 129 words and displaying garbage in the UI.
Discovered by @Daggolin

image

Ref #472

…not derived from OJK

UI_DrawGLInfo has an array of size 128, which was being filled from a GL extensions string of 129 words and displaying garbage in the UI.
Ref #472
@Razish Razish requested a review from a team as a code owner September 30, 2023 05:11
@Razish Razish merged commit 26b8719 into master Sep 30, 2023
24 checks passed
@Razish Razish deleted the fix-offbyone-glextensions-old-mods branch September 30, 2023 07:45
SomaZ added a commit to SomaZ/OpenJK that referenced this pull request Sep 30, 2023
taysta pushed a commit to taysta/TaystJK that referenced this pull request Oct 3, 2023
MaceMadunusus pushed a commit to MBII/OpenJK that referenced this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants