[SP] Font fixes #1227
Merged
[SP] Font fixes #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ir vanilla equivalents. This fixes JACoders#1226.
… font mapping with a dynamic list of up to 64 fonts. This might help with possible corner cases where custom assets have the menu loads differents fonts in place of the vanilla ones. The maximum of 64 fonts was chosen, because I wanted to avoid dynamic allocation. As the vanilla game only loads 5 different fonts and as I am not aware of custom mods that add a lot more I chose the value 64 to hopefully leave enough room for mods. The same change can NOT be applied to CG_MagicFontToReal, because the cgame module does not parse the menu files and does not know the order of fonts in menu files.
…ariant fonts. This fixes r_reloadfonts in SP.
Razish
approved these changes
Apr 7, 2024
SomaZ
approved these changes
Apr 7, 2024
Well, I was the one who ported the JK2MV font variant code to OpenJK and thought: for consistency I should add it to MP and SP. So I am the one who stepped into that trap of horrible SP font handling. Had I realized there is even magic numbers in the cgame module of SP I might have left out the SP support to avoid corner cases like this and just put a warning comment into the pull request. Now I am trying to fix what I broke. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes 2 bugs in SP:
Additionally it adjusts
MenuFontToRealin the ui module to be more flexible in case of menu files that don't actually load the default fonts.