bug fix for export returning empty sequence(s)

JBEI · Sep 4, 2020 · 2a44d01 · 2a44d01
1 parent 3beb506
commit 2a44d01
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/src/main/java/org/jbei/ice/lib/entry/EntriesAsCSV.java b/src/main/java/org/jbei/ice/lib/entry/EntriesAsCSV.java
@@ -227,7 +227,7 @@ private void writeZip(Set<Long> sequenceSet) {
             for (long entryId : sequenceSet) {
                 for (String format : formats) {
                     InputStreamWrapper wrapper = new PartSequence(userId, Long.toString(entryId))
-                            .toFile(SequenceFormat.fromString(format), true);
+                            .toFile(SequenceFormat.fromString(format), true, false);
                     putZipEntry(wrapper, zos);
                 }
             }
@@ -313,7 +313,7 @@ public ByteArrayOutputStream customize(EntrySelection selection, SequenceFormat
                 }
 
                 // get the sequence
-                InputStreamWrapper wrapper = new PartSequence(userId, Long.toString(entryId)).toFile(format, onePerFolder);
+                InputStreamWrapper wrapper = new PartSequence(userId, Long.toString(entryId)).toFile(format, onePerFolder, false);
                 if (wrapper == null) {
                     Logger.error("ERROR : no sequence " + entryId);
                     continue;

diff --git a/src/main/java/org/jbei/ice/lib/entry/sequence/PartSequence.java b/src/main/java/org/jbei/ice/lib/entry/sequence/PartSequence.java
@@ -495,19 +495,20 @@ private boolean checkSameFeature(SequenceFeature existingSequenceFeature, Sequen
     /**
      * Convert sequence to a byte array of the specified format with the intention of being written to a file
      *
-     * @param format      specified format for sequence conversion
-     * @param useFileName whether to use the original filename of the sequence if the original uploaded sequence is
-     *                    available
+     * @param format                 specified format for sequence conversion
+     * @param useFileName            whether to use the original filename of the sequence if the original uploaded sequence is
+     *                               available
+     * @param useOriginalIfAvailable whether to use specified format if is it the same as the uploaded format
      * @return wrapper around the outputstream for the converted format and name
      */
-    public InputStreamWrapper toFile(SequenceFormat format, boolean useFileName) {
+    public InputStreamWrapper toFile(SequenceFormat format, boolean useFileName, boolean useOriginalIfAvailable) {
         entryAuthorization.expectRead(userId, entry);
         Sequence sequence = sequenceDAO.getByEntry(entry);
         if (sequence == null)
             return null;
 
         // if requested format is the same as the original format (if original exist) then get the original instead
-        if (sequence.getFormat() == format && DAOFactory.getSequenceDAO().hasOriginalSequence(entry.getId()))
+        if (useOriginalIfAvailable && sequence.getFormat() == format && DAOFactory.getSequenceDAO().hasOriginalSequence(entry.getId()))
             format = SequenceFormat.ORIGINAL;
 
         String name;

diff --git a/src/main/java/org/jbei/ice/services/rest/FileResource.java b/src/main/java/org/jbei/ice/services/rest/FileResource.java
@@ -210,7 +210,7 @@ public Response downloadSequence(
 
             return addHeaders(Response.ok(stream), wrapper.getName());
         } else {
-            InputStreamWrapper wrapper = new PartSequence(userId, partId).toFile(SequenceFormat.fromString(downloadType), true);
+            InputStreamWrapper wrapper = new PartSequence(userId, partId).toFile(SequenceFormat.fromString(downloadType), true, true);
             StreamingOutput stream = output -> IOUtils.copy(wrapper.getInputStream(), output);
             return addHeaders(Response.ok(stream), wrapper.getName());
         }