Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize CSV validation and header mapping logic if header is enabled #115

Merged
merged 4 commits into from
Mar 30, 2024
Merged

Optimize CSV validation and header mapping logic if header is enabled #115

merged 4 commits into from
Mar 30, 2024

Commits on Mar 30, 2024

  1. Optimize CSV validation and header mapping logic if header is enabled 

    This commit addresses several changes in the CSV validation and header mapping logic. Firstly, a method to set IDs has been added in Column.php. Also, handling of headers in CSV files has been updated to better support files with and without headers. In addition, mapping of columns by header names has been moved to CsvFile.php from Schema.php for better alignment with data flow. Lastly, unnecessary exception throwing in getColumn method of Schema.php has been removed. Unit tests have also been updated to reflect these changes.
    @SmetDenis
    SmetDenis committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    2027c76 View commit details
    Browse the repository at this point in the history

  2. Refactored CSV header handling and column mapping logic 

    This commit includes implementing integer conversion for index mapping in CsvFile.php, which improves the header mapping logic. Furthermore, the header specification 'csv: header: false' has been removed from various test yaml files, implying a shift towards handling CSV files with headers. The changes collectively lead to a considerably streamlined CSV data processing workflow.
    @SmetDenis
    SmetDenis committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    de579ee View commit details
    Browse the repository at this point in the history

  3. Refactor Makefile to enhance benchmarking 

    This commit revamps the Makefile's BENCH_SCHEMAS variable to provide dynamic benchmarks selection. It also adjusts the benchmark-running targets to accommodate this change. These changes allow running different sets of benchmarks, improving overall benchmarking efficiency and customizability.
    @SmetDenis
    SmetDenis committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    23ccf34 View commit details
    Browse the repository at this point in the history

  4. Add 'name' attribute to column rules in benchmark files 

    This change introduces a new attribute, 'name', in column rules within various Benchmark files. It improves clarity and identification of rule sets by assigning each with a distinct 'name'. This adjustment enhances the overall testing practice and results in better data organization and manipulation.
    @SmetDenis
    SmetDenis committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    4f2ec37 View commit details
    Browse the repository at this point in the history