Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terminal width for GitHub actions and adjust schema examples #24

Merged
merged 9 commits into from
Mar 14, 2024

Conversation

SmetDenis
Copy link
Member

@SmetDenis SmetDenis commented Mar 14, 2024

This commit adjusts the terminal width configuration in ErrorSuite.php specifically for GitHub actions by adding a condition to set the maximum width to 150. Furthermore, the order of "str_ends_with" and "str_starts_with" properties in full.yml schema example file have been switched. Relevant changes are also echoed in the README.md file.

Denis Smet added 2 commits March 14, 2024 04:29
This commit adjusts the terminal width configuration in ErrorSuite.php specifically for GitHub actions by adding a condition to set the maximum width to 150. Furthermore, the order of "str_ends_with" and "str_starts_with" properties in full.yml schema example file have been switched. Relevant changes are also echoed in the README.md file.
The order of "str_ends_with" and "str_starts_with" properties in both full.json and full.php has been swapped for consistency and clarity. The README.md documentation has been updated to reflect these modifications in the schema examples.
@coveralls
Copy link

coveralls commented Mar 14, 2024

Pull Request Test Coverage Report for Build 8277592995

Details

  • 11 of 13 (84.62%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 95.435%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Utils.php 8 10 80.0%
Totals Coverage Status
Change from base Build 8273292984: -0.2%
Covered Lines: 669
Relevant Lines: 701

💛 - Coveralls

Denis Smet added 7 commits March 14, 2024 04:34
The usage syntax for csv-blueprint has been updated in the GithubActionsTest.php and README.md file to specify 'master' branch. This ensures that users always fetch the latest version when using the csv-blueprint action.
The terminal width determination code in ErrorSuite.php has been updated to include a check for a Docker environment. Additionally, utility methods for checking the Docker environment and Github Actions have been added in Utils.php for reusability. These changes will help refine terminal width estimates and enhance code organization.
The terminal width determination code in ErrorSuite.php has been updated to consider Docker environments. A new method, autoDetectTerminalWidth(), has been added for this functionality. Furthermore, in Utils.php, the isGithubActions() now includes a Docker environment check ensuring the functionality considers both contexts. This enhances reusability and precision in terminal width estimation.
String validation rules 'str_starts_with' and 'str_ends_with' were renamed to 'starts_with' and 'ends_with' for brevity and consistency. Also, a new utilitarian method named 'autoDetectTerminalWidth' was introduced to accurately estimate terminal width based on the execution environment. The code now takes into account wider terminal widths in Docker and GitHub actions environments.
The maximum auto-detected terminal width is adjusted for Docker containers from 120 characters to 140 characters. This considers the possibility of wider terminals in Docker environments, ensuring that the terminal output better accommodates for additional space.
Removed the assignment of the terminal width auto-detection to a variable in ErrorSuite.php and instead directly used it in the limit calculation. To improve clarity and maintain cleanliness of the code, comments related to terminal width auto-detection fall back have been moved to inside the autoDetectTerminalWidth function in Utils.php.
@SmetDenis SmetDenis merged commit 9242718 into master Mar 14, 2024
26 checks passed
@SmetDenis SmetDenis deleted the fix-table-ga branch March 14, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants