Switch aircraft record to first dimension #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecooke77
requested review from
ADCollard,
nicholasesposito and
BenjaminRuston
|
@nicholasesposito I'm happy to wait for ioda-converters to merge this or it could go in before. I'm don't mind either way. |
mikecooke77
added
the
coordinate merge
|
@mikecooke77 Yeah go for it. I'm testing the change now. |
5 tasks
BenjaminRuston
approved these changes
Oct 23, 2024
|
I think given this change fixes code that is currently in broken and under research this pr is ok to go in before the ioda-converters change linked to this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR switches the aircraft bias file so the dimensions are [Record, Variable] rather than [Variable, Record]. This is the style agreed at this discussion () and it fixes some tests failures with debug builds which don't collapse the array dimensions.
Issue(s) addressed
Resolves issues in ufo (e.g. https://github.com/JCSDA-internal/ufo/issues/3480)
Dependencies
To be merged with the associated ufo PR:
Impact
Ctests passing in debug builds.
Checklist