Conversation
hisonghy
reviewed
Jul 6, 2025
src/main/java/com/ject/studytrip/auth/application/facade/AuthFacade.java
Outdated
Show resolved
Hide resolved
hisonghy
reviewed
Jul 6, 2025
src/main/java/com/ject/studytrip/member/application/service/MemberService.java
Show resolved
Hide resolved
hisonghy
reviewed
Jul 6, 2025
src/main/java/com/ject/studytrip/auth/presentation/dto/request/KakaoLoginRequest.java
Show resolved
Hide resolved
hisonghy
reviewed
Jul 6, 2025
Contributor
hisonghy
left a comment
hisonghy
left a comment
There was a problem hiding this comment.
코드 리뷰 작성했습니다. 확인 부탁드려요.
hisonghy
reviewed
Jul 6, 2025
hisonghy
reviewed
Jul 8, 2025
...test/java/com/ject/studytrip/auth/presentation/controller/AuthControllerIntegrationTest.java
Show resolved
Hide resolved
* feat: BaseTimeEntity, Member, MemberRole, MemberCategory, SocialProvider 구현 * feat: JPA 엔티티의 생성/수정/삭제 시간 기록을 위한 JpaAuditingConfig 추가 * feat: WebClientConfig, KakaoOauthProperties, KakaoOauthClient, KakaoOauthProvider 구현 * feat: JwtTokenProperties, JwtTokenProvider 구현 * feat: KakaoUserInfoResponse, KakaoTokenResponse 구현 * feat: KakaoLoginService, KakaoLoginRequest, KakaoSignupRequest, TokenResponse 구현 * feat: MemberRepository, MemberJpaRepository, MemberRepositoryAdapter 구현 * feat: MemberErrorCode 정의 * feat: MemberFactory 구현 * feat: MemberService 구현 * feat: AuthFacade 구현 * feat: AuthController 구현 * feat: JwtFilter 구현 및 SecurityFilterChain 등록 * test: MemberFixture, KakaoOauthFixture, TokenFixture 생성 * test: MemberTestHelper 생성 * feat: KakaoLoginServiceTest 단위 테스트 추가 * test: MemberServiceTest 단위 테스트 추가 * test: AuthControllerIntegrationTest 통합 테스트 추가 * test: KakaoLoginServiceTest, MemberServiceTest, AuthControllerIntegrationTest @nested 어노테이션 적용
chaiminwoo0223
force-pushed
the
feature/15
branch
from
b3efa16 to
540b374
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 작업 내용 및 특이사항
✅ 로그인 흐름
✅ 도메인 및 인프라 구성
BaseTimeEntity,Member,MemberRole,MemberCategory,SocialProvider등 도메인 모델 구현JpaAuditingConfig를 통해 생성/수정/삭제 시간 자동 기록 기능 적용MemberRepository,MemberJpaRepository,MemberRepositoryAdapter)MemberFactory구현✅ 인증 및 로그인 기능 구현
WebClientConfig,KakaoOauthProperties,KakaoOauthClient,KakaoOauthProvider구현JwtTokenProperties,JwtTokenProvider,JwtFilter구현 및SecurityFilterChain에 등록KakaoLoginService,AuthFacade,AuthController구현✅ 예외 처리 고도화
AuthErrorCode: 카카오 로그인 및 인증 관련 예외 정의MemberErrorCode: 멤버 도메인 관련 예외 정의✅ TDD
BaseUnitTest기반):KakaoLoginServiceTest,MemberServiceTest,AuthFacadeTest추가BaseIntegrationTest기반):AuthControllerIntegrationTest추가MemberFixture,KakaoOauthFixture,TokenFixture추가MemberTestHelper추가🌱 관련 이슈
🔍 참고 자료
📚 기타
[Postman 응답 결과]
[MySQL 저장 확인]