feat: 미션, 학습기록, 데일리 미션, 데일리 목표 도메인 엔티티 생성(#24)#27
Merged
chaiminwoo0223 merged 1 commit intodevelopfrom Jul 13, 2025
Merged
Conversation
hisonghy
reviewed
Jul 13, 2025
Contributor
hisonghy
left a comment
There was a problem hiding this comment.
민우님이 말하신 것처럼 daily 라는 경로에 두거나, trip, mission 경로에 두는 것도 좋아보입니다.
DailyStudyLog도 확장성을 워해서 StudyLog로 변경하는 것도 괜찮아보여요
| @Column(nullable = false) | ||
| private String name; | ||
|
|
||
| private int order; |
Contributor
There was a problem hiding this comment.
MySQL에 order 라는 예약어가 존재해서 필드명을 missionOrder 처럼 수정해주거나 @Column(name = "mission_order") 설정을 추가 해주어야합니다
Stamp 엔티티를 생성할 때도 해당 이슈가 발생해서 필드명을 stampOrder로 변경했었습니다
Contributor
Author
There was a problem hiding this comment.
넵, 그럼 missionOrder로 수정하고 다시 올리겠습니다.
Contributor
Author
확인했습니다. 그럼 trip 패키지에 DailyGoal을 두고, mission 패키지에 DailyMission을 두는 형태로 수정하겠습니다. 그리고 DailyStudyLog도 StudyLog로 변경해서 다시 올리겠습니다. |
6c62fb0 to
235f8cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 작업 내용 및 특이사항
✅ 작업 내용
Mission,DailyGoal,DailyMission,StudyLog도메인 엔티티 생성BaseTimeEntity를 상속하여 생성/수정 시간 자동 관리of정적 팩토리 메서드로 처리✅ 특이사항
DailyGoal과DailyMission은 비즈니스적으로 밀접한 관계를 가지므로, daily 패키지로 통합하거나 trip, mission 패키지로 역할별 분리도 고려할 수 있습니다.DailyStudyLog는 확장 가능성을 고려해, 클래스명을StudyLog로 변경해도 좋을 것 같아요.🌱 관련 이슈
🔍 참고사항(선택)
📚 기타(선택)