refactor: 카카오 로그인 멤버 조회 로직 개선(#54)#56
Merged
chaiminwoo0223 merged 1 commit intodevelopfrom Aug 15, 2025
Merged
Conversation
* refactor: MemberService.getMemberBySocialProviderAndSocialId()에 MemberPolicy.validateNotDeleted() 추가 * test: MemberServiceTest에 탈퇴 회원 예외 발생 테스트 추가 * test: AuthControllerIntegrationTest에 탈퇴 회원 예외 발생 통합 테스트 추가 * test: KakaoOauthTestHelper 추가
hisonghy
approved these changes
Aug 15, 2025
Contributor
hisonghy
left a comment
hisonghy
left a comment
There was a problem hiding this comment.
고생하셨습니다.
이제 탈퇴한 회원이 로그인되는 상황이 발생하지 않아 더 안전한 로그인이 이루어지겠네요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 작업 내용 및 특이사항
✅ 카카오 로그인 멤버 조회 메서드에 삭제 검증 로직 추가
MemberService.getMemberBySocialProviderAndSocialId()에MemberPolicy.validateNotDeleted()추가✅ 테스트
MemberServiceTest:GetMemberBySocialProviderAndSocialId에 탈퇴 회원 예외 발생 테스트 추가AuthControllerIntegrationTest:KakaoLogin에 탈퇴 회원 예외 발생 테스트 추가KakaoOauthTestHelper추가🌱 관련 이슈
🔍 참고사항(선택)
KakaoOauthTestHelper를 통해 카카오 토큰 발급 및 사용자 정보 조회 Mocking을 간결하게 구성했습니다.📚 기타(선택)