Conversation
* refactor: 뽀모도로 엔티티 focusCount 필드 -> focusSessionCount 변경 * refactor: 뽀모도로 엔티티 생성 시 고정된 focusSessionCount 값을 지정하지 않고 요청받은 정보로 지정하도록 리팩토링 * refactor: CreatePomodoroRequest DTO focusSessionCount 필드 추가 * refactor: PomodoroInfo 클래스에 focusSessionCount 필드 추가 * refactor: LoadDailyGoalDetailResponse DTO pomodoro 정보에 focusSessionCount 필드 추가 * test: PomodoroService 단위 테스트의 뽀모도로를 생성하는 테스트 코드 수정 * test: DailyGoalController 통합 테스트에서 뽀모도로 focusSessionCount 관련 예외 발생 테스트 코드 추가
chaiminwoo0223
approved these changes
Aug 15, 2025
Contributor
chaiminwoo0223
left a comment
chaiminwoo0223
left a comment
There was a problem hiding this comment.
고생하셨습니다. 머지 부탁드려요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 작업 내용 및 특이사항
✅ 뽀모도로 엔티티 focusCount 필드명 수정
focusCount->focusSessionCount로 변경✅ 뽀모도로 집중 세션 개수를 함께 요청받도록 리팩토링
focusSessionCount(집중 세션 개수)도 함께 요청받아 뽀모도로 엔티티를 생성하도록 리팩토링CreatePomodoroRequestDTO에focusSessionCount필드 추가Pomodoro엔티티를 생성하는 of() 메서드에서focusSessionCount필드에 고정된 값 삭제✅ 뽀모도로 관련 응답 정보에 focusSessionCount 필드 추가
PomodoroInfo클래스에focusSessionCount필드 추가LoadDailyGoalDetailResponseDTOpomodoro필드에focusSessionCount필드 추가✅ 뽀모도로 집중 세션 개수 관련 테스트 코드 리팩토링 및 추가
🌱 관련 이슈
🔍 참고사항(선택)
📚 기타(선택)