Conversation
* refactor: Mission 엔티티 순서, 메모 필드 제거 * refactor: Mission 생성/수정, 쿼리 메서드, 검증/에러코드, DTO 리팩토링 * test: Mission 순서, 메모 관련 통합/단위 테스트 코드 리팩토링
chaiminwoo0223
approved these changes
Aug 16, 2025
Contributor
chaiminwoo0223
left a comment
There was a problem hiding this comment.
요청/응답 DTO 모두 동일한 필드를 사용하도록 하여 도메인 명확성이 높아진 것 같습니다. 이후 리팩토링 단계에서 다른 DTO들도 함께 개선하면 좋을 것 같아요.
Contributor
|
고생하셨습니다. 머지 부탁드립니다! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 작업 내용 및 특이사항
✅ Mission 엔티티 missionOrder(순서), memo(메모) 필드 제거
Mission엔티티의missionOrder(순서),memo(메모)필드를 제거했습니다.✅ Mission missionOrder(순서), memo(메모)와 관련된 로직 제거
Mission을 생성하는Mission.of(),MissionFactory.create()메서드에서missionOrder,memo필드를 제거했습니다.Mission을 수정하는Mission.update()메서드명을updateName()으로 변경하고,name필드만 수정하도록 리팩토링했습니다.MissionFacade,MissionService의 미션의 이름과 메모를 수정하는updateMissionNameAndMemoIfPresent()메서드를updateMissionNameIfPresent()로 변경했습니다.MissionController.updateMissionOrders,MissionFacade. updateMissionOrders,MissionService.updateMissionOrders)MissionRepository.findAllByStampIdAndDeletedAtIsNullOrderByMissionOrder)를createdAt기준으로 정렬하도록 변경하고, 미션 순서와 관련된 쿼리 메서드를 모두 제거했습니다. (MissionRepository.findAllByStampIdOrderByMissionOrder,MissionRepository.existsByStampIdAndMissionOrderAndDeletedAtIsNull)✅ 미션 생성/수정 요청 DTO name 필드명 변경
CreateMissionRequest,UpdateMissionRequestDTO 클래스의name필드명을missionName으로 변경했습니다.✅ 테스트
🌱 관련 이슈
🔍 참고사항(선택)
📚 기타(선택)