[FEAT] 이번주 인기 스테이 불러오기 api 연결 #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🪷 Storybook 확인 🪷 |
bykbyk0401
reviewed
Jan 21, 2025
| const PopularCarousel = () => { | ||
| const userId = localStorage.getItem('userId'); |
There was a problem hiding this comment.
현재 userId가 string으로 사용되고 있는데, 서버에서 Long으로 선언되어있으므로 Number로 반환하면 좋을 것 같아요!
|
|
||
| if (isError) { | ||
| return <p>Error</p>; | ||
| } |
There was a problem hiding this comment.
구현되어있는 로딩페이지와 에러페이지를 띄우도록 하면 좋을 것 같아요
Taew00k
reviewed
Jan 21, 2025
src/apis/ranking/index.ts
Outdated
|
|
||
| const useGetRanking = (userId: string | null) => { | ||
| const { data, isLoading, isError } = useQuery<RankingResponse>({ | ||
| queryKey: ['rankiing', userId], |
seong-hui
approved these changes
Jan 23, 2025
| import { privateInstance } from '@apis/instance'; | ||
|
|
||
| const getRanking = async (userId: number | null) => { | ||
| const res = await privateInstance.get('/ranking', { |
There was a problem hiding this comment.
현재 privateInstance로 연결하고 있는데 해당 인기스테이에서 로그인하지 않은 사용자도 불러올 수 있으니 해당 부분 추후에 수정이 필요할 것으로 보입니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛰️ 관련 이슈
🧑💻 작업 내용
🗯️ PR 포인트
🚀 알게된 점
📖 참고 자료 (선택)
📸 스크린샷 (선택)