Skip to content

Aero and vol uncertainty scalar changes#756

Merged
kdorheim merged 3 commits intodevfrom
dev4
May 29, 2025
Merged

Aero and vol uncertainty scalar changes#756
kdorheim merged 3 commits intodevfrom
dev4

Conversation

@kdorheim
Copy link
Contributor

This PR is for recent (post V3.2) developments but introduces major changes, so I wanted to keep it separate from #755 in case we wanted to have the option to do a minor release.

  • Alpha and Volscl impact RF output #745 Change implementation of the volcanic and aerosol scalars; this causes changes in volcanic RF and aerosol RF output otherwise, there are no other model output behavior changes. The code-breaking change from the new ini file structure.

(IMPORTANT NOTE: this PR documentation will need to be updated to reflect merged PRs)

Here we change where the scalers are applied so that the vol, aerosol, and total forcing outputs are updated appropriately. While this PR does not change hector output or behavior between the parameter name change, there are code-breaking changes that have been made to the ini files. The ini files are not backward compatible. 

---------

Co-authored-by: ptrscll <ptrscll@gmail.com>
@github-actions
Copy link

Differences in Hector outputs

Hello, this is leeyabot!

The current pull request's outputs do not differ from 3.1.1 (d931a00).

@github-actions
Copy link

Differences in Hector outputs

Hello, this is leeyabot!

The current pull request's outputs differ from 3.1.1 (d931a00) as follows:

R squared NRMSE
CO2_concentration 1.000 0.001
global_tas 1.000 0.183
RF_CO2 1.000 0.173
RF_tot 1.000 0.282


@kdorheim kdorheim marked this pull request as ready for review May 29, 2025 18:35
@kdorheim kdorheim changed the title Code breaking development Aero and vol uncertainty scalar changes May 29, 2025
@kdorheim kdorheim merged commit 68a7a0d into dev May 29, 2025
@kdorheim kdorheim deleted the dev4 branch May 29, 2025 18:49
@kdorheim kdorheim mentioned this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant