Merge pull request #29 from JHWelch/enable-max-len

Enable max-len rule

.eslintrc.cjs

@@ -11,6 +11,12 @@ module.exports = {
     'comma-dangle': ['error', 'always-multiline'],
     'no-console': ['error', { allow: ['warn', 'error'] }],
     indent: ['error', 2],
+    'max-len': ['error', {
+      ignoreStrings: true,
+      ignoreTrailingComments: true,
+      ignoreUrls: true,
+      tabWidth: 2,
+    }],
     'object-curly-spacing': ['error', 'always'],
     quotes: ['error', 'single'],
     semi: ['error', 'never'],

__tests__/controllers/cacheController.spec.ts

@@ -18,6 +18,13 @@ let notionMock: NotionMock
 
 const { res, mockClear } = getMockRes()
 
+const newCacheController = () => {
+  const firestore = new FirestoreAdapter()
+  const notion = new NotionAdapter()
+  const tmdbAdapter = new TmdbAdapter()
+  return new CacheController(firestore, notion, tmdbAdapter)
+}
+
 beforeAll(() => {
   jest.mock('@notionhq/client')
   jest.mock('firebase-admin/app')
@@ -34,9 +41,6 @@ beforeEach(() => {
 })
 
 describe('cache', () => {
-  let firestore: FirestoreAdapter
-  let notion: NotionAdapter
-  let tmdbAdapter: TmdbAdapter
   let req: Request
 
   describe('when the cache is empty', () => {
@@ -47,14 +51,11 @@ describe('cache', () => {
         NotionMock.mockWeek('id2', '2021-01-08', 'theme2'),
         NotionMock.mockWeek('id3', '2021-01-15', 'theme3'),
       ])
-      firestore = new FirestoreAdapter()
-      notion = new NotionAdapter()
-      tmdbAdapter = new TmdbAdapter()
       req = getMockReq()
     })
 
     it('updates all weeks in firestore', async () =>  {
-      const cacheController = new CacheController(firestore, notion, tmdbAdapter)
+      const cacheController = newCacheController()
 
       await cacheController.cache(req, res)
 
@@ -107,17 +108,14 @@ describe('cache', () => {
         NotionMock.mockWeek('id1', '2021-01-01', 'theme1', false, [notionResponse]),
       ])
       notionMock.mockRetrieve(notionResponse)
-      firestore = new FirestoreAdapter()
-      notion = new NotionAdapter()
-      tmdbAdapter = new TmdbAdapter()
       req = getMockReq()
       const tmdbMock = new TmdbMock(mockFetch())
       tmdbMock.mockSearchMovie(tmdb)
       tmdbMock.mockMovieDetails(tmdb)
     })
 
     it('stores data from tmdb in firestore', async () => {
-      const cacheController = new CacheController(firestore, notion, tmdbAdapter)
+      const cacheController = newCacheController()
 
       await cacheController.cache(req, res)
 

__tests__/support/fetchMock.ts

@@ -1,9 +1,14 @@
 import { jest } from '@jest/globals'
 
-export type MockFetch = jest.Mock<(input: RequestInfo | URL, init?: RequestInit | undefined) => Promise<Response>>
+type FetchFunction = (
+  input: RequestInfo | URL,
+  init?: RequestInit | undefined
+) => Promise<Response>;
+
+export type MockFetch = jest.Mock<FetchFunction>
 
 export function mockFetch (): MockFetch {
-  const mockFetch = jest.fn<(input: RequestInfo | URL, init?: RequestInit | undefined) => Promise<Response>>()
+  const mockFetch = jest.fn<FetchFunction>()
   global.fetch = mockFetch
 
   return mockFetch

__tests__/support/notionMock.ts

@@ -31,7 +31,9 @@ export class NotionMock {
   mockRetrieve = (movie: NotionMovie | undefined = undefined) => {
     const notionMovie = movie ?? NotionMovie.demo()
 
-    this.retrieve.mockImplementation(async (args: WithAuth<GetPageParameters>): Promise<GetPageResponse> => {
+    this.retrieve.mockImplementation(async (
+      args: WithAuth<GetPageParameters>
+    ): Promise<GetPageResponse> => {
       const { page_id } = args as { page_id: string }
 
       if (page_id !== notionMovie.id) {
@@ -45,7 +47,9 @@ export class NotionMock {
 
   mockQuery = (weeks: PageObjectResponse[] = []) => {
     this.query.mockImplementation(
-      async (_args: WithAuth<QueryDatabaseParameters>): Promise<QueryDatabaseResponse> => ({
+      async (
+        _args: WithAuth<QueryDatabaseParameters>
+      ): Promise<QueryDatabaseResponse> => ({
         page_or_database: {},
         type: 'page_or_database',
         object: 'list',