Merge pull request #32 from JHWelch/handle-movie-not-found

Handle movie not found
JHWelch · Aug 12, 2023 · ca3d91a · ca3d91a
2 parents d39b16d + 0119c09
commit ca3d91a
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 5 deletions.
diff --git a/__tests__/data/tmdb/tmdbAdapter.spec.ts b/__tests__/data/tmdb/tmdbAdapter.spec.ts
@@ -34,4 +34,14 @@ describe('getMovie', () => {
 
     expect(movie).toEqual(expected)
   })
+
+  describe('when movie is not found', () => {
+    it('should return undefined', async () => {
+      tmdbMock.mockSearchMovie(undefined)
+
+      const movie = await tmdbAdapter.getMovie('movie title')
+
+      expect(movie).toBeUndefined()
+    })
+  })
 })
diff --git a/__tests__/support/tmdbMock.ts b/__tests__/support/tmdbMock.ts
@@ -7,11 +7,11 @@ export class TmdbMock {
     private mockFetch: MockFetch
   ) {}
 
-  mockSearchMovie (movie: Movie, id = 1234)  {
+  mockSearchMovie (movie: Movie | undefined, id = 1234)  {
     this.mockFetch
       .mockImplementationOnce(async () => new Response(JSON.stringify({
         page: 1,
-        results: [
+        results: movie ? [
           {
             id: id,
             original_title: movie.title,
@@ -28,9 +28,9 @@ export class TmdbMock {
             vote_average: 7.282,
             vote_count: 3953,
           },
-        ],
+        ] : [],
         total_pages: 1,
-        total_results: 9,
+        total_results: movie ? 1 : 0,
       })))
   }
 

diff --git a/src/controllers/cacheController.ts b/src/controllers/cacheController.ts
@@ -29,6 +29,8 @@ export default class CacheController {
   async fillMovieDetails (movies: Movie[]): Promise<void> {
     await Promise.all(movies.map<Promise<void>>(async movie => {
       const tmdbMovie = await this.tmdbAdapter.getMovie(movie.title)
+      if (!tmdbMovie) return
+
       movie.merge(tmdbMovie)
     }))
   }

diff --git a/src/data/tmdb/tmdbAdapter.ts b/src/data/tmdb/tmdbAdapter.ts
@@ -4,9 +4,11 @@ import MovieResponse from './dtos/movieResponse.js'
 import SearchResponse from './dtos/searchResponse.js'
 
 export default class TmdbAdapter {
-  async getMovie (name: string): Promise<Movie> {
+  async getMovie (name: string): Promise<Movie | undefined> {
     const search = await this.searchMovie(name)
 
+    if (search.results.length === 0) return undefined
+
     return await this.movieDetails(search.results[0].id)
   }