-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type Definitions #10
Comments
I was looking into this and found this repo, which implements another I was messing around with the types and noticed all the function types need to be arrow functions rather than instance methods (what we have right now). I'm not 100% sure how these are mapped right now, but apparently everything is working as expected. I'm going to update the types and change around how we declare the methods to be arrow functions and open a PR. edit I did more digging into the types and noticed something. The arrow functions are defined via some type definitions, but they actually seem wrong, in that every implementation of the session store I've seen uses edit after even more digging I ran into this issue, which talks about having Generally the DT versions are a mess, if that wasn't clear with all my above comments haha. Basically fixing the types now against the As such the internal existing types should be good enough, I'll update just the public facing api to match with the |
@bradtaniguchi Thanks for the work on this! I was struggling trying to figure out the whole instance method vs instance function error. Your digging seems to have discovered why 👍 I'll go ahead and merge the PR and we'll keep a look out for updated |
I'm the author of the PR you linked, and yes, the DT typings are an absolute mess. |
Because |
It has been 20 months, but I'm happy to say that DefinitelyTyped/DefinitelyTyped#46576 has just been merged! |
@HoldYourWaffle Thanks! Seemed like a real battle to get it through! Going to be looking into refactoring the types here with the new changes :D Thanks for all the effort! |
Need to straighten out type definitions. Currently, Store accepts an argument of session with type
any
and returns with typeany
. In turn, does not properly supply types.The text was updated successfully, but these errors were encountered: