Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/packages #34

Closed
wants to merge 2 commits into from
Closed

Update/packages #34

wants to merge 2 commits into from

Conversation

JLuboff
Copy link
Owner

@JLuboff JLuboff commented Dec 2, 2020

Brad... Can you review? I've updated all packages including @types/express-session. I'm not positive what we need to do to update the original typings that you had done?

@bradtaniguchi
Copy link
Collaborator

bradtaniguchi commented Dec 3, 2020

Yea let me review/bring up the old conversation to get some context to why the types should of changed. I vaguely remembered it all dealing with how the types had () => instead of methods, when the actual implementation should be methods.

Here's the post with the most detail:
#10 (comment)

@JLuboff JLuboff closed this Dec 4, 2020
@JLuboff JLuboff deleted the update/packages branch October 28, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants