Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add primes_geq and primes_lt generation functions, as well as sieve_geq and sieve_lt. #19

Merged
merged 213 commits into from
May 7, 2024

Conversation

JSorngard
Copy link
Owner

Also adds an Error type to facilitate the change. Future work: Also make the sieving functions take two generics.

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 93.95%. Comparing base (f7989c0) to head (f820bba).

Files Patch % Lines
src/generation.rs 89.21% 22 Missing ⚠️
src/sieving.rs 91.07% 10 Missing ⚠️
src/wrapper.rs 81.81% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   93.01%   93.95%   +0.93%     
==========================================
  Files           4        7       +3     
  Lines         687      843     +156     
==========================================
+ Hits          639      792     +153     
- Misses         48       51       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JSorngard JSorngard merged commit 667c3fa into main May 7, 2024
12 of 14 checks passed
@JSorngard JSorngard deleted the largest_primes_below branch May 7, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant