Fix a bug where primes_lt and sieve_lt could panic if the underlying segmented sieve happend to run down past 0.
#55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd use that signal in sieve_lt and primes_lt
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
+ Coverage 88.51% 89.62% +1.11%
==========================================
Files 11 11
Lines 1123 1157 +34
==========================================
+ Hits 994 1037 +43
+ Misses 129 120 -9 ☔ View full report in Codecov by Sentry. |
JSorngard
changed the title
primes_lt and sieve_lt could panic if the segmented sieve happend to run down past 0.primes_lt and sieve_lt could panic if the underlying segmented sieve happend to run down past 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now instead we reuse the base sieve, and read from it at an offset.