Skip to content

Make crate conditionally no_std in such a way that the implicit prelude is always the same #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 3, 2025

Conversation

JSorngard
Copy link
Owner

@JSorngard JSorngard commented Jan 2, 2025

And the add std as an extern crate when the std feature is enabled.

This makes the implicit prelude the same regardless of whether the std feature is enabled or not.

Additional information: https://www.reddit.com/r/rust/comments/1hs6spy/psa_for_std_feature_in_no_std_libraries/

JSorngard and others added 4 commits January 3, 2025 00:02
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3a58efe) to head (ca2ae0f).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #57   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines         1596      1596           
=========================================
  Hits          1596      1596           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JSorngard JSorngard closed this Jan 2, 2025
@JSorngard JSorngard deleted the JSorngard-patch-1 branch January 2, 2025 23:15
@JSorngard JSorngard restored the JSorngard-patch-1 branch January 3, 2025 13:01
@JSorngard JSorngard reopened this Jan 3, 2025
@JSorngard JSorngard merged commit 90cf007 into main Jan 3, 2025
9 checks passed
@JSorngard JSorngard deleted the JSorngard-patch-1 branch January 3, 2025 13:05
@JSorngard JSorngard changed the title Make crate unconditionally no_std Make crate conditionally no_std in such a way that the implicit prelude is always the same Jan 3, 2025
@JSorngard JSorngard added enhancement New feature or request dependencies Pull requests that update a dependency file labels Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants