Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the hand implementations of the rational functions with a single generic one #70

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

JSorngard
Copy link
Owner

The hand made implementations were a left over from when features could be activated to evaluate the polynomials with Estrin's scheme instead of Horner's method. They are no longer needed and can be made generic.

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ac48cd8) to head (556395b).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #70   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         1600      1587   -13     
=========================================
- Hits          1600      1587   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JSorngard
Copy link
Owner Author

JSorngard commented Jan 23, 2025

Benchmarks show a performance reduction of between 2 and 11 percent.

I will only merge this if I can figure out how to remove the performance reduction.

@JSorngard JSorngard changed the title Replace the hand implementations of rational functions with generic ones Replace the hand implementations of rational functions with a generic one Jan 23, 2025
@JSorngard JSorngard changed the title Replace the hand implementations of rational functions with a generic one Replace the hand implementations of the rational functions with a single generic one Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants