-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added logic to import multiple files when prompted (fixes issues #31) #40
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, but the nesting looks pretty deep (admittedly, it was deep prior). I think this could be improved by factoring out the core of the loop into another function.
Hopefully, this should improve readability a bit with processing the file. I did two other things:
|
Looks good to me :) (I have not tested this though) |
Thanks for taking a look at it. Any idea who has permission to merge? I noticed that there's only one merge from August. |
AFAIK only @Jack000 can merge them |
should we start a development branch somewhere until jack returns? |
I'm in favour of that, without it, projects become abandonware. I'm just about to to the same on GerberTools. Just make sure you add a new issue to point people to where the new code is. |
Is jack also @bmtm ? |
Not directly related to the PS. |
I'll review & merge PRs on my fork until @Jack000 is available: https://github.com/InfernoEmbedded/Deepnest |
Fixes #31