Refactor: Introduce use case for icon pack filtering and add search #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o UI
This commit refactors how icon pack data is loaded and introduces a new search feature in the icon selection dialog.
A new `GetIconPackInfosUseCase` has been created to encapsulate the logic of parsing and filtering icon pack components. This use case now filters icons by component name, ensuring that only relevant icons are shown for a specific application.
The `EditApplicationInfoViewModel` has been updated to use this new use case instead of directly accessing the `IconPackManager`.
### Key Changes:
* **`domain/use-case`**:
* Created `GetIconPackInfosUseCase` to handle fetching and filtering of `IconPackInfoComponent`s from an icon pack's `appfilter.xml`.
* The use case filters icons based on both `packageName` and `component`, improving the relevance of the displayed icons.
* **`feature/edit-application-info`**:
* `EditApplicationInfoViewModel` now depends on `GetIconPackInfosUseCase` instead of `IconPackManager`.
* The `updateIconPackInfoPackageName` function now accepts a `component` string to pass to the new use case for more accurate filtering.
* **`ui`**:
* Added a `SearchBar` to the `IconPackInfoFilesDialog`. This allows users to search for specific icons within an icon pack.
* Minor layout adjustments were made to accommodate the new search bar.
|
Oh, you rockstars. That was super fast, going to have to try this again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #479
This commit refactors how icon pack data is loaded and introduces a new search feature in the icon selection dialog.
A new
GetIconPackInfosUseCasehas been created to encapsulate the logic of parsing and filtering icon pack components. This use case now filters icons by component name, ensuring that only relevant icons are shown for a specific application.The
EditApplicationInfoViewModelhas been updated to use this new use case instead of directly accessing theIconPackManager.Key Changes:
domain/use-case:GetIconPackInfosUseCaseto handle fetching and filtering ofIconPackInfoComponents from an icon pack'sappfilter.xml.packageNameandcomponent, improving the relevance of the displayed icons.feature/edit-application-info:EditApplicationInfoViewModelnow depends onGetIconPackInfosUseCaseinstead ofIconPackManager.updateIconPackInfoPackageNamefunction now accepts acomponentstring to pass to the new use case for more accurate filtering.ui:SearchBarto theIconPackInfoFilesDialog. This allows users to search for specific icons within an icon pack.