Skip to content

fix: Fail fast when VNC password file creation fails instead of starting without auth #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cubic-dev-ai wants to merge 1 commit into
base: feat/add-webcontainers
Choose a base branch
from
Open

fix: Fail fast when VNC password file creation fails instead of starting without auth #214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions sandbox-templates/expo-android/start_android.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,24 @@ fluxbox &
# Generate VNC password if not exists
VNC_PASSWD_FILE="/home/user/.vnc_passwd"
if [ ! -f "$VNC_PASSWD_FILE" ]; then
echo "vncpasswd" | head -1 > "$VNC_PASSWD_FILE" 2>/dev/null || true
echo "[INFO] Creating VNC password file..."
mkdir -p /home/user
echo "vncpasswd" | head -1 > "$VNC_PASSWD_FILE" 2>/dev/null
if [ $? -ne 0 ] || [ ! -f "$VNC_PASSWD_FILE" ]; then
echo "[ERROR] Failed to create VNC password file. Exiting to prevent unauthenticated VNC access."
exit 1
fi
fi

# Verify VNC password file exists before starting server
if [ ! -f "$VNC_PASSWD_FILE" ]; then
echo "[ERROR] VNC password file not found at $VNC_PASSWD_FILE. Refusing to start VNC without authentication."
exit 1
fi

# Start VNC server with password authentication
echo "[INFO] Starting VNC server on port 5900..."
if [ -f "$VNC_PASSWD_FILE" ]; then
x11vnc -display :99 -forever -shared -rfbport 5900 -rfbauth "$VNC_PASSWD_FILE" &
else
echo "[WARN] VNC password file not found, starting without authentication"
x11vnc -display :99 -forever -shared -rfbport 5900 &
fi
x11vnc -display :99 -forever -shared -rfbport 5900 -rfbauth "$VNC_PASSWD_FILE" &

# Wait for display services
sleep 2
Expand Down
Loading