Skip to content

fixing the convex error #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jackson57279 merged 1 commit into from
Aug 7, 2025
Merged

fixing the convex error #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions convex/rateLimit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ export async function checkRateLimit(
throw new Error("Authentication required for rate limiting");
}

// Periodically clean up expired entries to prevent memory leaks
if (Math.random() < 0.01) { // 1% chance to cleanup on each call
cleanupExpiredRateLimits();
}

const config = RATE_LIMITS[operation];
const key = `${identity.subject}:${operation}`;
const now = Date.now();
Expand Down Expand Up @@ -95,9 +100,9 @@ export async function enforceRateLimit(
}

/**
* Clean up expired rate limit entries (should be called periodically)
* Clean up expired rate limit entries (called during rate limit checks)
*/
export function cleanupExpiredRateLimits(): void {
function cleanupExpiredRateLimits(): void {
const now = Date.now();
for (const [key, entry] of rateLimitStore.entries()) {
if (now > entry.resetTime) {
Expand All @@ -106,9 +111,6 @@ export function cleanupExpiredRateLimits(): void {
}
}

// Clean up expired entries every 5 minutes
setInterval(cleanupExpiredRateLimits, 5 * 60 * 1000);

/**
* Get current rate limit status for a user and operation
*/
Expand Down
Loading