Skip to content

Potential fix for code scanning alert no. 186: Incomplete multi-character sanitization #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jackson57279 merged 1 commit into from
Aug 13, 2025
Merged

Potential fix for code scanning alert no. 186: Incomplete multi-character sanitization #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions src/lib/search-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,19 +316,10 @@ export class BraveSearchService {
}

private extractTextContent(html: string): string {
// Repeatedly remove <script> and <style> tags and their content
let sanitized = html;
let previous;
do {
previous = sanitized;
sanitized = sanitized
.replace(/<script[^>]*>.*?<\/script>/gis, '')
.replace(/<style[^>]*>.*?<\/style>/gis, '');
} while (sanitized !== previous);
return sanitized
.replace(/<[^>]*>/g, ' ')
.replace(/\s+/g, ' ')
.trim();
// Use cheerio to robustly remove <script> and <style> tags and extract text
const $ = cheerio.load(html);
$('script, style').remove();
return $.root().text().replace(/\s+/g, ' ').trim();
}
}

Expand Down
Loading