Skip to content

Potential fix for code scanning alert no. 123: DOM text reinterpreted as HTML #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jackson57279 merged 1 commit into from
Aug 16, 2025
Merged

Potential fix for code scanning alert no. 123: DOM text reinterpreted as HTML #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/components/ChatInterface.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,18 @@ import { DECISION_PROMPT_NEXT } from '@/lib/decisionPrompt';

const { logger } = Sentry;

// Helper to sanitize URLs for use in href attributes
function getSafeUrl(url: string): string {
try {
const urlObj = new URL(url);
if (urlObj.protocol === 'http:' || urlObj.protocol === 'https:') {
return urlObj.toString();
}
} catch {
// Invalid URL
}
return '#';
}
// Security constants for input validation
const MAX_MESSAGE_LENGTH = 10000;
const MAX_TITLE_LENGTH = 100;
Expand Down Expand Up @@ -907,8 +919,8 @@ const ChatInterface: React.FC = () => {
<div className="space-y-3 text-sm">
<div>
<span className="font-medium">URL:</span>
<a href={websiteAnalysis.url} target="_blank" rel="noopener noreferrer" className="text-primary hover:underline ml-1">
{websiteAnalysis.url}
<a href={getSafeUrl(websiteAnalysis.url)} target="_blank" rel="noopener noreferrer" className="text-primary hover:underline ml-1">
<SafeText text={websiteAnalysis.url} />
</a>
</div>
{websiteAnalysis.title && (
Expand Down
Loading