Upgrade to latest vsts linux installer and add validation for bad chars#15
Open
akomakom wants to merge 1 commit intoJacobHenner:masterfrom
Open
Upgrade to latest vsts linux installer and add validation for bad chars#15akomakom wants to merge 1 commit intoJacobHenner:masterfrom
akomakom wants to merge 1 commit intoJacobHenner:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest linux installer adds escaping of the systemd unit filename via
systemd-escape --pathwhich screws things up for the optimistic service naming. This PR ensures that the issue is caught early.Alternatives:
regsubst($agent_name, '-', '_', 'G'). (possibly disruptive)TBH I haven't considered other possible bad chars, but I figured that dashes would be fairly common.