forked from ovn-kubernetes/ovn-kubernetes
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
use a forked version of j-keck/arping that fixes a threading issue
here is the PR for the upstream version j-keck/arping#17 ' using sock.deinitialize() outside of the goroutine that is using the socket leaves the potential for erroneous and unexpected behavior. When calling Ping() very quickly the socket fd can be reused while a goroutine is still trying to read from it and cause the goroutine to deadlock. Additionally removing the timeout from the select case because that will/cannot work as intended. In linux close() does not cause system calls using the socket to return. This contributes to the file descriptor reuse issue mentioned above and with the defered sock.deinitialize() can lead to double closing the socket. ' Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
- Loading branch information
1 parent
6c1417b
commit 03d94ec
Showing
7 changed files
with
20 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
9 changes: 9 additions & 0 deletions
9
go-controller/vendor/github.com/j-keck/arping/arping_linux.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
28 changes: 0 additions & 28 deletions
28
go-controller/vendor/github.com/j-keck/arping/arping_windows.go
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters