Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix miscellaneous #53

Merged
merged 3 commits into from
Jan 19, 2025
Merged

Fix miscellaneous #53

merged 3 commits into from
Jan 19, 2025
+97 −142

Conversation

Ichunjo
Copy link
Contributor

@Ichunjo Ichunjo commented Jan 17, 2025

  • Fix Morpho calls
  • Fix mypy errors
  • Simplify fine_dehalo2 code (maybe need fact checks)
  • Fix vine_dehalo

@Ichunjo
Copy link
Contributor Author

Ichunjo commented Jan 19, 2025

About fine_dehalo2:

  • mode type specifies one dimensionnal convolution mode only.
  • Remove planes parameter since the function only works on luma plane.
  • Fix docstring.
  • Remove complexpr_available if statement cope code and use vsrgtools.BlurMatrix
  • First clamping is done in the expr
  • The convolutions for the halo fixes are done automatically but I'm still skeptical about the formula.
  • Remove second complexpr_available if statement since it would only succeed on FLOAT clip.

@emotion3459 emotion3459 merged commit ff88863 into Jaded-Encoding-Thaumaturgy:master Jan 19, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ichunjo @emotion3459