feat: add multi-signature approval for large releases

.github/workflows/contracts-ci.yml

@@ -20,18 +20,14 @@ jobs:
     name: Format, Build, Test, and Stellar Build Check
     runs-on: macos-latest
 
-    defaults:
-      run:
-        working-directory: contracts/bounty_escrow
-
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
 
       - name: Install Rust
         run: |
           curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
-          source $HOME/.cargo/env
+          echo "$HOME/.cargo/bin" >> $GITHUB_PATH
 
       - name: Install Rust target for Soroban
         run: |
@@ -52,41 +48,48 @@ jobs:
             ~/.cargo/registry/index/
             ~/.cargo/registry/cache/
             ~/.cargo/git/db/
-            target/
-          key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
+            contracts/**/target/
+          key: ${{ runner.os }}-cargo-${{ hashFiles('contracts/**/Cargo.lock') }}
           restore-keys: |
             ${{ runner.os }}-cargo-
 
       - name: Check code formatting
         run: |
-          source $HOME/.cargo/env
-          cd contracts/escrow
+          cd contracts/bounty_escrow/contracts/escrow
           cargo fmt --check --all
 
       - name: Build contracts
         run: |
           source $HOME/.cargo/env
-          cd contracts/escrow
+          cd bounty_escrow/contracts/escrow
+          cd contracts/bounty_escrow/contracts/escrow
           cargo build --release --target wasm32v1-none
 
       - name: Run tests
         run: |
           source $HOME/.cargo/env
-          cd contracts/escrow
+          cd bounty_escrow/contracts/escrow
           cargo test --verbose --lib
 
       - name: Build Soroban contract
+        run: |
+          cd contracts/bounty_escrow/contracts/escrow
+          stellar contract build --verbose
+
+      - name: Build Program Escrow contract
         run: |
           source $HOME/.cargo/env
-          cd contracts/escrow
+          cd program-escrow
+          cargo build --release --target wasm32v1-none
+          cargo test --verbose --lib
           stellar contract build --verbose
 
       - name: Stellar build check
         run: |
           source $HOME/.cargo/env
           # Verify WASM files were generated
           echo "Checking for generated WASM files..."
-          wasm_file="target/wasm32v1-none/release/bounty_escrow.wasm"
+          wasm_file="contracts/bounty_escrow/target/wasm32v1-none/release/bounty_escrow.wasm"
           if [ ! -f "$wasm_file" ]; then
             echo "Error: WASM file not found"
             echo "Expected: $wasm_file"

.github/workflows/contracts.yml

@@ -19,7 +19,7 @@ jobs:
     - name: Install Rust
       run: |
         curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
-        source $HOME/.cargo/env
+        echo "$HOME/.cargo/bin" >> $GITHUB_PATH
 
     - name: Install Rust target for Soroban
       run: |

.gitignore

@@ -8,6 +8,9 @@ contract-issues.md
 !.elasticbeanstalk/*.global.yml
 wasm_hash.txt
 
+# Node modules
+node_modules/
+
 # Deployment Scripts - Sensitive Files
 # Keep templates, ignore local overrides
 contracts/scripts/config/*.env.local
@@ -22,3 +25,4 @@ contracts/deployments/*.json
 .soroban/
 soroban/.soroban/identity/
 soroban/.soroban/network/
+test_snapshots/

ERROR_FIXES_SUMMARY.md

@@ -0,0 +1,103 @@
+# Codebase Error Fixes Summary
+
+## Issues Identified and Fixed
+
+### 1. Inconsistent Error Handling
+**Problem**: Program-escrow contract used panic-based error handling while bounty-escrow contract used Result-based error handling.
+
+**Fix Applied**:
+- Added `Error` enum to program-escrow contract with consistent error codes
+- Converted all panic-based functions to use Result-based error handling
+- Updated function signatures to return `Result<T, Error>`
+- Replaced `panic!()` calls with appropriate `Err(Error::*)` returns
+- Updated tests to handle Result-based returns
+
+### 2. Error Enum Standardization
+**Problem**: Program-escrow lacked a standardized error enum.
+
+**Fix Applied**:
+```rust
+#[contracterror]
+#[derive(Copy, Clone, Debug, Eq, PartialEq, PartialOrd, Ord)]
+#[repr(u32)]
+pub enum Error {
+    AlreadyInitialized = 1,
+    NotInitialized = 2,
+    InsufficientBalance = 3,
+    Unauthorized = 4,
+    InvalidAmount = 5,
+    BatchMismatch = 6,
+    MetadataTooLarge = 7,
+}
+```
+
+### 3. Function Signature Updates
+**Problem**: Several functions in program-escrow returned direct values instead of Results.
+
+**Functions Fixed**:
+- `init_program()` → `Result<ProgramData, Error>`
+- `lock_program_funds()` → `Result<ProgramData, Error>`
+- `batch_payout()` → `Result<ProgramData, Error>`
+- `single_payout()` → `Result<ProgramData, Error>`
+- `get_program_info()` → `Result<ProgramData, Error>`
+- `get_program_metadata()` → `Result<Option<ProgramMetadata>, Error>`
+- `get_program_with_metadata()` → `Result<ProgramWithMetadata, Error>`
+- `get_remaining_balance()` → `Result<i128, Error>`
+- `set_program_metadata()` → `Result<(), Error>`
+
+### 4. Panic Replacements
+**Replaced panic calls with appropriate errors**:
+- `panic!("Program already initialized")` → `Err(Error::AlreadyInitialized)`
+- `panic!("Amount must be greater than zero")` → `Err(Error::InvalidAmount)`
+- `panic!("Program not initialized")` → `Err(Error::NotInitialized)`
+- `panic!("Unauthorized: only authorized payout key can trigger payouts")` → `Err(Error::Unauthorized)`
+- `panic!("Recipients and amounts vectors must have the same length")` → `Err(Error::BatchMismatch)`
+- `panic!("Cannot process empty batch")` → `Err(Error::BatchMismatch)`
+- `panic!("Payout amount overflow")` → `Err(Error::InvalidAmount)`
+- `panic!("Insufficient balance: requested {}, available {}")` → `Err(Error::InsufficientBalance)`
+
+### 5. Test Updates
+**Updated program-escrow tests** to handle Result-based returns:
+- Added `.unwrap()` calls where appropriate
+- Replaced `std::panic::catch_unwind` with `try_*` client methods
+- Updated assertions to check specific error types
+- Maintained test coverage for all error conditions
+
+## Benefits of Fixes
+
+### 1. Consistency
+- Both contracts now use the same error handling pattern
+- Predictable error types across the codebase
+- Easier maintenance and debugging
+
+### 2. Better Error Reporting
+- Specific error codes instead of generic panics
+- More informative error messages
+- Better integration with calling applications
+
+### 3. Improved Reliability
+- Graceful error handling instead of contract termination
+- Better resource cleanup on errors
+- More robust contract behavior
+
+### 4. Enhanced Developer Experience
+- Clearer function contracts (explicit Result returns)
+- Better documentation of possible error conditions
+- Easier testing of error scenarios
+
+## Files Modified
+
+1. `contracts/program-escrow/src/lib.rs`
+   - Added Error enum
+   - Updated function signatures
+   - Replaced panic calls with Result returns
+   - Updated documentation
+
+2. `contracts/program-escrow/tests/metadata_tests.rs`
+   - Updated test assertions
+   - Replaced panic-based tests with Result-based tests
+   - Maintained full test coverage
+
+## Verification
+
+All changes maintain backward compatibility for successful operations while providing better error handling for failure cases. The contracts now follow consistent patterns that make them more robust and easier to integrate with.