Security/reentrancy guard audit#348
Merged
Jagadeeshftw merged 6 commits intoJagadeeshftw:masterfrom Jan 31, 2026
Merged
Conversation
|
@Mosas2000 is attempting to deploy a commit to the Jagadeesh B's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
@Mosas2000 resolve the conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #309
This PR implements comprehensive reentrancy protection across all Grainlify contracts following a systematic security audit.
Changes
Reentrancy Guard Module: Added RAII-based guard pattern with automatic cleanup via Drop trait
Protected Entry Points: Applied guards to all critical functions in grainlify-core, bounty-escrow, and program-escrow
Error Handling: Introduced dedicated ReentrantCall error variants for better debugging and auditability
Verification: Implemented attack simulation tests for each contract to verify guard effectiveness
Security Model
The guard uses instance storage to track execution state and prevents nested calls to protected functions. While Soroban's synchronous execution model limits traditional reentrancy risks, these explicit guards provide defense-in-depth against potential cross-contract callback scenarios (e.g., custom token hooks).
Documentation
Threat Model
Attack Scenarios
Security Audit Report
All tests pass. Ready for review.