test: use non i18n props for validation endpoint testing#123
Merged
baptistegrimaud merged 1 commit intomainfrom Jun 5, 2025
Merged
test: use non i18n props for validation endpoint testing#123baptistegrimaud merged 1 commit intomainfrom
baptistegrimaud merged 1 commit intomainfrom
Conversation
baptistegrimaud
force-pushed
the
tests-failing-on-jahia-8.1.7
branch
from
8e67fa4 to
e879b5b
Compare
jkevan
approved these changes
Jun 4, 2025
Contributor
jkevan
left a comment
jkevan
left a comment
There was a problem hiding this comment.
Is there a plan to investigate the i18n property validation issue ?
Contributor
Author
#125 has been created |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #120.
Use simple String non-internationalized properties to test the GraphQL validation endpoint.
The reason behind this change is that currently the nightly tests are failing when running against a Jahia 8.1.7.x (see this run for example).
For some reasons, in Jahia 8.1.7.x, the locale is not passed correctly to the validation process, which results in the validators (in our case, the
HtmlFilteringValidator) to not have access to the 81n props, hence not being able to validate them correctly.