Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BACKLOG-22005 Migrate and improve html filtering api #4

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

AKarmanov
Copy link
Contributor

JIRA

https://jira.jahia.org/browse/BACKLOG-22005

Description

Migrate and improve html filtering api

@AKarmanov AKarmanov requested a review from a team January 12, 2024 15:36
Copy link
Contributor

@gflores-jahia gflores-jahia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add jahia-depends for graphql-dxm module (as done on sitesettings previously)

Copy link
Contributor

@gflores-jahia gflores-jahia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding tests (or modify existing ones) on the new APIs, or as a followup PR.

One thing to consider for testing is to keep existing filtering tests that uses the JCR graphql mutation/query APIs since this is what content-editor uses at least for sanity check. For the filtering test API, maybe not necessary to add right now if it's only done strictly for testing purposes, but can be used later for more extensive filtering scenarios as needed.

@AKarmanov
Copy link
Contributor Author

Consider adding tests (or modify existing ones) on the new APIs, or as a followup PR.

One thing to consider for testing is to keep existing filtering tests that uses the JCR graphql mutation/query APIs since this is what content-editor uses at least for sanity check, but we can use filtering tests API for more extensive filtering scenarios as needed.

Will do as part of my new task for dryrun parameter

@AKarmanov AKarmanov merged commit 0a342f9 into main Jan 12, 2024
5 checks passed
@AKarmanov AKarmanov deleted the BACKLOG-22005 branch January 12, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants