Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BACKLOG-23326: Increase the default statusMatchCount in waitUntilSAMStatus from 1 to 3 #92

Merged
merged 1 commit into from
Oct 23, 2024
Merged

BACKLOG-23326: Increase the default statusMatchCount in waitUntilSAMStatus from 1 to 3 #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@jahia/cypress",
"version": "3.29.0",
"version": "3.30.0",
"scripts": {
"build": "tsc",
"lint": "eslint src -c .eslintrc.json --ext .ts"
Expand Down
4 changes: 2 additions & 2 deletions src/utils/SAMHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@
* @param probeHealthFilter the filter for the health check probes, default is GREEN
* @param timeout the timeout in milliseconds, default is 60000
* @param interval the interval in milliseconds, default is 500
* @param statusMatchCount the number of consecutive status matches before the waitUntil resolves, default is 1
* @param statusMatchCount the number of consecutive status matches before the waitUntil resolves, default is 3
*/
export const waitUntilSAMStatus = ({expectedHealth, severity = 'MEDIUM', probeHealthFilter = 'GREEN', timeout = 60000, interval = 500, statusMatchCount = 1}) : void => {
export const waitUntilSAMStatus = ({expectedHealth, severity = 'MEDIUM', probeHealthFilter = 'GREEN', timeout = 60000, interval = 500, statusMatchCount = 3}) : void => {

Check warning on line 33 in src/utils/SAMHelper.ts

View workflow job for this annotation

GitHub Actions / Lint and build 

Object pattern argument should be typed
let statusCount = 0;
let lastGraphqlResponse = {};
cy.waitUntil(() =>
Expand Down
Loading