Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BACKLOG-23496: limit cover title length #87

Merged
merged 1 commit into from
Jan 10, 2025
Merged

BACKLOG-23496: limit cover title length #87

merged 1 commit into from
Jan 10, 2025

Conversation

GauBen
Copy link
Member

@GauBen GauBen commented Jan 10, 2025

https://jira.jahia.org/browse/BACKLOG-23496

Description

Fix for this bug:

image


Fixed by two means:

  • Title length is now limited to 140 chars, which more than enough for a cover title

image
140-char title

image
Error if the title is too long

  • The cover crops its content if it overflows

image

Tests

The following are included in this PR

  • Unit Tests (Most changes should have unit tests)
  • Integration Tests

Checklist

I have considered the following implications of my change:

  • Security (in particular for changes to authentication, authorization, data fetching, ...)
  • Performance
  • Migration
  • Code maintainability

Documentation

  • Inline documentation
  • Internal Documentation (wiki)
  • User-facing Documentation

@GauBen
Copy link
Member Author

GauBen commented Jan 10, 2025

Also updated jahia scripts hoping it would fix the development workflow, it did

@GauBen
Copy link
Member Author

GauBen commented Jan 10, 2025

To review: I also added a constraint on "teaser"

@GauBen GauBen merged commit bf6ff66 into main Jan 10, 2025
4 checks passed
@GauBen GauBen deleted the BACKLOG-23496 branch January 10, 2025 13:01
GauBen added a commit that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants