Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BACKLOG-23496: limit cover title length #87

Merged
merged 1 commit into from
Jan 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"@cyclonedx/webpack-plugin": "^3.12.0",
"@heroicons/react": "^2.1.1",
"@jahia/eslint-config": "^2.1.2",
"@jahia/scripts": "^1.3.6",
"@jahia/scripts": "^1.3.7",
"babel-loader": "^8.2.3",
"babel-plugin-transform-react-remove-prop-types": "^0.4.24",
"clean-webpack-plugin": "^4.0.0",
Expand Down
4 changes: 2 additions & 2 deletions settings/definitions.cnd
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
- enableAgencies (boolean) = true

[luxe:header] > jnt:content, luxemix:luxeContent
- title (string) primary i18n mandatory
- teaser (string) i18n
- title (string) primary i18n mandatory < '.{0,140}'
- teaser (string) i18n < '.{0,200}'
- image (weakreference, picker[type='image']) < 'jmix:image'

[luxe:highlightNumber] > jnt:content, luxemix:luxeContent
Expand Down
1 change: 1 addition & 0 deletions src/scss/styles.scss
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
.lux-cover {
position: relative;
min-height: 695px;
overflow: hidden; // Prevent the text from spilling over other sections
}

.lux-cover_img {
Expand Down
44 changes: 7 additions & 37 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1434,16 +1434,7 @@ __metadata:
languageName: node
linkType: hard

"@babel/runtime@npm:^7.23.2":
version: 7.24.0
resolution: "@babel/runtime@npm:7.24.0"
dependencies:
regenerator-runtime: "npm:^0.14.0"
checksum: 10c0/3495eed727bf4a4f84c35bb51ab53317ae38f4bbc3b1d0a8303751f9dfa0ce6f5fb2afced72b76c3dd0d8bb2ccb84787559a4dee9886291a36b26f02f0f759b4
languageName: node
linkType: hard

"@babel/runtime@npm:^7.23.9":
"@babel/runtime@npm:^7.23.2, @babel/runtime@npm:^7.23.9, @babel/runtime@npm:^7.8.4":
version: 7.24.4
resolution: "@babel/runtime@npm:7.24.4"
dependencies:
Expand All @@ -1452,15 +1443,6 @@ __metadata:
languageName: node
linkType: hard

"@babel/runtime@npm:^7.8.4":
version: 7.23.9
resolution: "@babel/runtime@npm:7.23.9"
dependencies:
regenerator-runtime: "npm:^0.14.0"
checksum: 10c0/e71205fdd7082b2656512cc98e647d9ea7e222e4fe5c36e9e5adc026446fcc3ba7b3cdff8b0b694a0b78bb85db83e7b1e3d4c56ef90726682b74f13249cf952d
languageName: node
linkType: hard

"@babel/template@npm:^7.22.15, @babel/template@npm:^7.23.9":
version: 7.23.9
resolution: "@babel/template@npm:7.23.9"
Expand Down Expand Up @@ -1681,9 +1663,9 @@ __metadata:
languageName: node
linkType: hard

"@jahia/scripts@npm:^1.3.6":
version: 1.3.6
resolution: "@jahia/scripts@npm:1.3.6"
"@jahia/scripts@npm:^1.3.7":
version: 1.3.7
resolution: "@jahia/scripts@npm:1.3.7"
dependencies:
cross-spawn: "npm:^7.0.1"
dotenv: "npm:^8.2.0"
Expand All @@ -1703,7 +1685,7 @@ __metadata:
jahia-prepare-build: prepare-build.js
jahia-publish: publish.js
jahia-react2dts: react2dts.js
checksum: 10c0/2d3e766cf8b4add99c65df2d8089d6052d75cecfee363f86d2a041e880c81df8fb0cd465c8957f258d0c63443da86693e8843f1f33f59251ecc6ddd5b46e5541
checksum: 10c0/21da2a89e1b5c6c7c12704f5e9970da034a5aa3abcd55f8a9c7698a76f2a15985b3ff4fae8d4615c8e65a6cc4bc216b84827c3c24b948f0b8e1baba0e76015ee
languageName: node
linkType: hard

Expand Down Expand Up @@ -2422,19 +2404,7 @@ __metadata:
languageName: node
linkType: hard

"ajv@npm:^8.0.0, ajv@npm:^8.9.0":
version: 8.12.0
resolution: "ajv@npm:8.12.0"
dependencies:
fast-deep-equal: "npm:^3.1.1"
json-schema-traverse: "npm:^1.0.0"
require-from-string: "npm:^2.0.2"
uri-js: "npm:^4.2.2"
checksum: 10c0/ac4f72adf727ee425e049bc9d8b31d4a57e1c90da8d28bcd23d60781b12fcd6fc3d68db5df16994c57b78b94eed7988f5a6b482fd376dc5b084125e20a0a622e
languageName: node
linkType: hard

"ajv@npm:^8.12.0":
"ajv@npm:^8.0.0, ajv@npm:^8.12.0, ajv@npm:^8.9.0":
version: 8.13.0
resolution: "ajv@npm:8.13.0"
dependencies:
Expand Down Expand Up @@ -6060,7 +6030,7 @@ __metadata:
"@heroicons/react": "npm:^2.1.1"
"@jahia/eslint-config": "npm:^2.1.2"
"@jahia/javascript-modules-library": "npm:^0.0.4"
"@jahia/scripts": "npm:^1.3.6"
"@jahia/scripts": "npm:^1.3.7"
babel-loader: "npm:^8.2.3"
babel-plugin-transform-react-remove-prop-types: "npm:^0.4.24"
bootstrap: "npm:^5.3.3"
Expand Down
Loading