Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BACKLOG-23563: added cloudimage example #102

Merged
merged 1 commit into from
Jan 28, 2025
Merged

BACKLOG-23563: added cloudimage example #102

merged 1 commit into from
Jan 28, 2025

Conversation

GauBen
Copy link
Member

@GauBen GauBen commented Jan 27, 2025

Description

Added an example of reactive image using <picture> for JSX

Tests

The following are included in this PR

  • Unit Tests (Most changes should have unit tests)
  • Integration Tests

Checklist

I have considered the following implications of my change:

  • Security (in particular for changes to authentication, authorization, data fetching, ...)
  • Performance
  • Migration
  • Code maintainability

Documentation

  • Inline documentation
  • Internal Documentation (wiki)
  • User-facing Documentation

hduchesne
hduchesne approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@hduchesne hduchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe think later to unify the DAM ready code and cloudimage
getUrl(['width:1920']) vs ?w=1920&h=695

@hduchesne hduchesne merged commit c1cfb87 into main Jan 28, 2025
5 checks passed
@hduchesne hduchesne deleted the BACKLOG-23563 branch January 28, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hduchesne hduchesne hduchesne approved these changes

@baptistegrimaud baptistegrimaud Awaiting requested review from baptistegrimaud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GauBen @hduchesne