Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean code #5

Merged
merged 1 commit into from
Feb 8, 2024
Merged

clean code #5

merged 1 commit into from
Feb 8, 2024

Conversation

hduchesne
Copy link
Collaborator

create Destination template and update Destinations review params name
finish the resources bundle for Fr, Es, De and En.

JIRA

https://jira.jahia.org/browse/PROJECT-XXX

Description

Tests

The following are included in this PR

  • Unit Tests (Most changes should have unit tests)
  • Integration Tests

Checklist

I have considered the following implications of my change:

  • Security (in particular for changes to authentication, authorization, data fetching, ...)
  • Performance
  • Migration
  • Code maintainability

Documentation

  • Inline documentation
  • Internal Documentation (wiki)
  • User-facing Documentation

create Destination template and update Destinations
review params name
finish the resources bundle for Fr, Es, De and En.
@hduchesne hduchesne merged commit 692897c into main Feb 8, 2024
1 check passed
@hduchesne hduchesne deleted the develop branch February 8, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant